Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: slapi-nis - NIS Server and Schema Compatibility plugins for Fedora DS https://bugzilla.redhat.com/show_bug.cgi?id=456150 rcritten@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |rcritten@xxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From rcritten@xxxxxxxxxx 2008-07-23 17:49 EST ------- Review: + package builds in mock (F8 x86_64). - rpmlint reports the following errors and warnings: rpmlint reports 1 error and 1 warning: slapi-nis.x86_64: I: checking slapi-nis.x86_64: E: summary-too-long NIS Server and Schema Compatibility plugins for Fedora and Red Hat Directory Server The "Summary:" must not exceed 79 characters. slapi-nis.x86_64: W: incoherent-version-in-changelog 0.2-1 0.6-1.fc8 The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. 1 packages and 0 specfiles checked; 1 errors, 1 warnings. + source files match upstream. e9bc790e51187f3afa13dc2611e5d93a python-kerberos-1.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + License is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears consistent. + Compiler flags are honored correctly. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does own the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Removes the buildroot in %install I haven't tested that the plugin doesn't cause FDS to core yet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review