Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pdfmerge - Command line utility program for merging PDF files https://bugzilla.redhat.com/show_bug.cgi?id=456331 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Summary|Review Request: pdfmerge - |Review Request: pdfmerge - |Command line utility program|Command line utility program |for merging PDF files |for merging PDF files Flag| |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-07-23 01:13 EST ------- Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=733245 + rpmlint is silent for SRPM and for RPM. + source files match upstream url acb9fc8a65e3524dd1077d7285650c49 pdfmerge-1.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + package installed successfully. SHOULD: Change License text to GPLv2+ Change Source url to Source0: http://downloads.sourceforge.net/pdfmerge4unix/%{name}-%{version}.tar.gz APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review