Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Package Review: perl-Convert-BER - ASN.1 Basic Encoding Rules Alias: perl-Convert-Ber-r. https://bugzilla.redhat.com/show_bug.cgi?id=455172 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-07-23 00:43 EST ------- Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=733103 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 00fd5e5a98d4194da0e980186cba6292 Convert-BER-1.3101.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=10, Tests=401, 1 wallclock secs ( 0.12 usr 0.01 sys + 0.43 cusr 0.02 csys = 0.58 CPU) + Package perl-Convert-BER-1.3101-2.fc10 => Provides: perl(Convert::BER) = 1.31 perl(Convert::BER::ANY) perl(Convert::BER::BER) perl(Convert::BER::BIT_STRING) perl(Convert::BER::BIT_STRING8) perl(Convert::BER::BOOLEAN) perl(Convert::BER::CHOICE) perl(Convert::BER::CONSTRUCTED) perl(Convert::BER::INTEGER) perl(Convert::BER::NULL) perl(Convert::BER::OBJECT_ID) perl(Convert::BER::OPTIONAL) perl(Convert::BER::REAL) perl(Convert::BER::SEQUENCE) perl(Convert::BER::SEQUENCE_OF) perl(Convert::BER::STRING) perl(Convert::BER::_Time_generic) Requires: perl(Exporter) perl(integer) perl(strict) perl(vars) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review