Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xslthl - XSLT Syntax Highlighting for saxon and xalan https://bugzilla.redhat.com/show_bug.cgi?id=455358 ------- Additional Comments From dev@xxxxxxxxxx 2008-07-22 07:38 EST ------- Hmmm so I should have taken a sneak peak at the spec file before, here are some initial concerns: - The spec file is licensed - Not good, might be an idea to rewrite from scratch. - Epoch: is not needed as it's zero - Another 'bad thing' in Fedora - We don't require that packages have Requires for /bin/rm and /bin/ln, you can safely assume that these exist - According to https://fedoraproject.org/wiki/Packaging/Java -- The jpackage-utils dependency need to have a firm dependency as well (not just a post/postun) -- You don't need epochs for dependencies when they are 0, It builds so your mostly there, but I'd sooner it be closer to the guidelines before I give it the big tick (hopefully any furthur changes would be minor enough you can just fix them upon import :)) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review