Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: griv - a gtk rivchat https://bugzilla.redhat.com/show_bug.cgi?id=454166 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-07-21 12:13 EST ------- (In reply to comment #10) > >Why? Unless using "--delete-original", this is needed (if --vendor fedora is > specified) > Because either --delete-original in desktop-file-install or an exclude line in > %files can be used Well, slightly unrelated to this, however I usually recommend _not_ to use %exclude but to remove files explicitly unless avoided such cases like - Some complicated %files entry description like a situation in which some files in a same directories are packaged in different subpackages - .py{o,c} under %_bindir ... especially when including binaries (for this package, desktop file is a text file and --delete-original can be used here). For binaries, using %exclude makes debuginfo rpm larger unneededly (because splitted out part of binaries are included into debuginfo rpm even if they are %exclude'd). To avoid further issues I don't know, I recommend not to use %exclude. > >> - please use either RPMBUILDROOT or rpmbuildroot, but not both > >Where is it used? > desktop-file-install --vendor="fedora" \ > --dir=$RPM_BUILD_ROOT%{_datadir}/applications \ > %{buildroot}/%{_datadir}/applications/%{name}.desktop > > (obviously, in #8 I meant %buildroot not rpmbuildroot ) Ah, okay, sorry for not noticing this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review