Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: gnome-disk-utility - GNOME Disk Utility https://bugzilla.redhat.com/show_bug.cgi?id=456034 ------- Additional Comments From mclasen@xxxxxxxxxx 2008-07-21 11:49 EST ------- package name: ok spec file name: ok packaging guidelines: - source tag should be fixed up according to https://fedoraproject.org/wiki/Packaging/SourceURL - the description should be more than a repetition of the summary. Ideally 1-2 complete sentences. license: ok license field: ok license file: ok spec language: ok spec legibility: ok upstream sources: ok, but see above for the source tag buildable: ok ExcludeArch: n/a BuildRequires: missing PolicyKit-gnome-devel, libsexy-devel, intltool locale handling: - you should use find-lang --with-gnome %{name}, then it also picks up the translated docs and adds proper %locale tags for them ldconfig: ok relocatable: n/a directory ownership: - /usr/share/omf/palimpsest/ needs to be owned. See above for how to fix that with find-lang - /usr/include/gnome-disk-utility/ must be owned duplicate files: ok permissions: libs and ui-libs are missing a %defattr %clean: ok macro use: consistent content: permissible large docs: n/a %doc content: ok headers: ok static libs: n/a pc files: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok directory ownership: ok %install: ok utf8 filenames: ok -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review