Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: DeviceKit - Device Enumeration Framework https://bugzilla.redhat.com/show_bug.cgi?id=456032 ------- Additional Comments From mclasen@xxxxxxxxxx 2008-07-21 10:54 EST ------- package name: ok spec file name: ok packaging guidelines: - you should probably straighten the %doc stuff - Source: points to a nonexisting location, should just make it a filename and add a comment explaining that it is a git snapshot license: ok license field: ok license file: ok spec language: ok spec legibility: ok upstream sources: ok, see above for Source: tag problem ExcludeArch: n/a BuildRequires: ok locale handling: ok ldconfig: ok relocatable: n/a directory ownership: - need to Requires: udev for /etc/udev/rules.d duplicate files: ok permissions: ok %clean: ok macro use: consistent content: permissible large docs: n/a doc content: ok headers: ok static libs: n/a pc files: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: n/a file/directory ownership: - /usr/share/dbus-1/interfaces should be owned by dbus %install: ok utf8 filenames: ok -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review