Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Thibault-fonts - Collection of fonts from thibault.org https://bugzilla.redhat.com/show_bug.cgi?id=454128 ------- Additional Comments From sundaram@xxxxxxxxxx 2008-07-18 17:06 EST ------- Fix the rpmlint warnings. While the mixed tab and spacing warnings are less serious, the permissions are definitely wrong. srpm: thibault-fonts.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) thibault-fonts.src: W: strange-permission Essays1743-1.0-ttf.tar.gz 0777 thibault-fonts.src: W: strange-permission Rockets-ttf.tar.gz 0777 thibault-fonts.src: W: strange-permission StayPuft.tar.gz 0777 thibault-fonts.src: W: strange-permission Isabella.tar.gz 0777 1 packages and 0 specfiles checked; 0 errors, 5 warnings. Spec file: thibault-fonts.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. OK | MUST: The package must be named according to the Package… OK | MUST: The spec file name must match the base package… OK | MUST: The package must meet the Packaging Guidelines… OK | MUST: The package must be licensed with a Fedora approved… OK | MUST: The License field in the package spec file must… OK | MUST: Packaged detached license and specified in %doc OK | MUST: The spec file for the package MUST be legible. OK | MUST: The package must successfully compile and build… OK | MUST: successfully compile, build OK | MUST: All build dependencies must be listed… OK | MUST: A package must own all directories that it creates OK | MUST: A package must not contain any duplicate files NOK | MUST: Permissions on files must be set properly. Please fix the incorrect permissions OK | MUST: Each package must have a %clean section OK | MUST: Each package must consistently use macros OK | MUST: The package must contain code, or permissible OK | MUST: Packages must not own files or directories already OK | MUST: At the beginning of %install, each package MUST… OK | MUST: All filenames in rpm packages must be valid UTF-8. OK | SHOULD: If the source package does not include license OK | SHOULD: The description and summary section … translations… OK | SHOULD: The package builds in mock OK | SHOULD: The package builds on all supported architectures OK | SHOULD: The reviewer should test that the package… OK | SHOULD: If scriptlets are used, those scriptlets must be sane… Add a font config file as described in http://fedoraproject.org/wiki/Annotated_fonts_spec_template and in http://fedoraproject.org/wiki/Fontconfig_packaging_tips -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review