Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Xpad - Sticky notepad for GTK+2 https://bugzilla.redhat.com/show_bug.cgi?id=455069 thomas.moschny@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |thomas.moschny@xxxxxx ------- Additional Comments From thomas.moschny@xxxxxx 2008-07-18 14:20 EST ------- [x] = ok, [!] = not ok, [-] = not applicable [x] package meets naming guidelines [x] specfile is encoded in ascii or utf-8 [x] specfile matches base package name [x] specfile uses macros consistently [x] specfile is written cleanly [x] specfile is written in AE [x] changelog is present and has correct format [x] license matches actual license [x] license is open source-compatible [x] license text is included in package [x] source tag has correct url [x] source files match upstream md5sum: 1e12e6aec8f03a656eb6427ba22c38d3 [x] latest version is packaged [x] summary is concise [x] dist tag is present [x] buildroot is correct [x] buildroot is prepped [x] %clean is present [!] proper build requirements libICE-devel is already required by libSM-devel [!] proper requirements require hicolor-icon-theme (owns /usr/share/icons/hicolor/scalable/apps) [x] uses %{?_smp_mflags} [x] uses %{optflags} [x] doesn't use %makeinstall [x] package builds at least on one architecture tested on: f9/x86_64 [x] packages installs and runs at least on one architecture tested on: f9/x86_64 [x] rpmlint is quiet [x] final provides/requires look sane [-] ldconfig called in %post and %postun if required [x] code, not content [x] file permissions are appropriate [x] debuginfo package looks usable [-] config files marked as %config(noreplace) [!] owns all the directories it creates see above [-] static libraries in -devel subpackage [-] header files in -devel subpackage [-] development .so files in -devel subpackage [-] pkgconfig files in -devel subpackage, requires pkgconfig [x] no .la files [x] doesn't need a -docs subpackage [!] relevant docs are included please add NEWS, THANKS and TODO [x] doc files are not needed at runtime [x] provides a .desktop file, build-requires desktop-file-utils [x] uses %find_lang, build-requires gettext minor issue: replace "%{_mandir}/man1/%{name}.1.*" with "%{_mandir}/man1/%{name}.1*" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review