Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: florence - Florence is an extensible scalable on-screen virtual keyboard for GNOME https://bugzilla.redhat.com/show_bug.cgi?id=454208 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-07-18 10:33 EST ------- Interesting package. Some random notes for 0.2.2-2: * License - As far as I checked the whole codes, the license tag should be "GPLv2+ and GFDL". * CFLAGS - The following lines: --------------------------------------------------------------- CFLAGS="${CFLAGS:-$RPM_OPT_FLAGS}" export CFLAGS --------------------------------------------------------------- are redundant and should be removed (please check what %configure actually does by $ rpm --eval %configure ) * desktop-file-install usage --------------------------------------------------------------- desktop-file-install --vendor="fedora" \ --dir=$RPM_BUILD_ROOT%{_datadir}/applications \ %{buildroot}/%{_datadir}/applications/%{name}.desktop rm -f $RPM_BUILD_ROOT%{_datadir}/applications/%{name}.desktop --------------------------------------------------------------- - You can use --delete-original option (please check $ desktop-file-install --help) * GConf scriptlets - For GConf scriptlets, please refer to http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf %post scriptlet is missing - Also please add proper "Requires(pre)" or so. - We regards GConf schemas files as _not_ a configuration file so please remove %config(noreplace) attribution on GConf schemas file (even if rpmlint warns about it) * sed call on %post - Modifying %{_sysconfdir}/gconf/schemas/%{name}.schemas (using sed) must not be done on scriptlets but must be done before %install finishes. * Directory ownership issue - Please make it sure that all directories created when installing this package are correctly owned by this package. For example, the directory %{_datadir}/%{name}/ is not owned by any package. ! NOTE When you write ----------------------------------------------------------------------- %files %defattr(-,root,root,-) %{_datadir}/%{name}/ ----------------------------------------------------------------------- This contains the directory %{_datadir}/%{name} itself and all files/ directories/etc under %{_datadir}/%{name}, while ----------------------------------------------------------------------- %files %dir %{_datadir}/%{name}/ ------------------------------------------------------------------------ contains the directory %{_datadir}/%{name} only. * Documents - Please add the following files to %doc: ------------------------------------------------------------------------ COPYING-DOCS NEWS ------------------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review