Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-taglib - Ruby library wrapping the Taglib library https://bugzilla.redhat.com/show_bug.cgi?id=453944 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-07-18 09:26 EST ------- Thank you for your review! * About patch name: ----------------------------------------------------------- (In reply to comment #1) > Perhaps you might want to use %{name}-%{version} in the names of the patches as > well? Just a suggestion.. Using macros (especially like %version) causes the change of the patches' names every time source package is upgraded, while it is very possible that patches need not be upgraded even if the source changes. So usually I recommend not to use macros (especially %{version}) for patches' names. New Package CVS Request ======================= Package Name: ruby-taglib Short Description: Ruby library wrapping the Taglib library Owners: mtasaka Branches: F-9 F-8 InitialCC: (nobody) Cvsextras Commits: welcome -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review