Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Tk-TableMatrix - Perl module for creating and manipulating tables https://bugzilla.redhat.com/show_bug.cgi?id=444745 xavier@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx ------- Additional Comments From xavier@xxxxxxxxxxxx 2008-07-18 08:13 EST ------- Builds fine in mock. BR: are ok. The tests should not be excluded unconditionally, a method to enable them on a local build should be provided. Use something like : %check %{?_with_tests:make test} rpmlint output is not empty, but the warnings are ok : perl-Tk-TableMatrix.i386: W: devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Tk/pTk/tkTableversion.h perl-Tk-TableMatrix.i386: W: devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Tk/pTk/tkTable.h perl-Tk-TableMatrix.i386: W: devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Tk/pTk/mm.h perl-Tk-TableMatrix.i386: W: devel-file-in-non-devel-package /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Tk/pTk/version.h Requires and provides look sane. The demos subdir should probably be added to %%doc. The ChangeLog file should also be added to %%doc. The license issue seems tricky. The package itself is GPL+ or Artistic, but the pTk/ subdir is MIT and the pTk/mTk/ subdir is MIT too. btw, only the main COPYING file is added, pTk/license.terms and pTk/mTk/license.terms should probably be added to %%doc. As you noted previously, it would be good to look at removing the included pTK and pTk/mTk, if at all possible, both for not duplicating code and to ease the license issue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review