Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kpackagekit - KDE packagekit interface https://bugzilla.redhat.com/show_bug.cgi?id=455700 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2008-07-17 19:00 EST ------- A few initial comments: 1. drop qt4-devel (kdelibs-devel pulls that in already) 2. BR: kdelibs4-devel 3. drop hard-coded Requires: PackageKit-libs (auto deps should find this). Not sure about 'PackageKit' 4. drop -DCMAKE_SKIP_RPATH:BOOL=ON (should be included in standard/default %cmake macro already). 5. for betas/prelreleases, should use a Release tag something like: Release: 0.1.%{betaversion} instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review