Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libixp - stand-alone client/server 9P library including ixpc client https://bugzilla.redhat.com/show_bug.cgi?id=454025 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-07-17 13:26 EST ------- Hello: * Please support parallel make when possible: https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make If not possible, write a comment in the spec file that this package does not support parallel make * build log like: ------------------------------------------------------------- + make MAKE all libixp/ HEADER include/ixp_fcall.h from fcall.h.nounion CC libixp/client.o CC libixp/convert.o CC libixp/error.o CC libixp/intmap.o ------------------------------------------------------------- is not useful. We cannot verify if Fedora specific compiler flags are correctly honored on this package from this build log: https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags And actually currently this compiler flags (you can check this by $ rpm --eval %optflags) are not correctly honored. Please make build log more verbose (you can do this by removing ".SILENT" from makefiles by for example: ------------------------------------------------------------------------------ find . -type f | xargs grep -l '.SILENT' | xargs sed -i.silent -e 's|\.SILENT||' ------------------------------------------------------------------------------ ) * Please use macros properly. /usr must be %{_prefix}, /etc must be %{_sysconfdir} https://fedoraproject.org/wiki/Packaging/RPMMacros * When packaging static archives follow: https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries * This package does not build on x86_64 (I cannot show x86_64 build log because currently koji is very slow...) static archives are installed under /usr/lib even on x86_64 (which is wrong for 64 bits machine) where spec files expects that static archives should be installed under %_libdir (on 64 bits machine this is /usr/lib64). * Usually -devel package must have "Requires: %{name} = %{version}-%{release}" (please check: https://fedoraproject.org/wiki/Packaging/ReviewGuidelines ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review