Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cpqarrayd - daemon to monitor HP (compaq) arraycontrollers https://bugzilla.redhat.com/show_bug.cgi?id=455699 dan@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From dan@xxxxxxxx 2008-07-17 05:20 EST ------- OK source files match upstream: 9d76dfe75507eabcc9e406bc88eeab7a660b057f cpqarrayd-2.3.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPLv2+). License text not included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. N/A owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. some notes: - ask upstream to run automake with the "--copy" to include not the links but real copies of files in the source archive - I would enclose the support for IDA in #ifdef WITH_IDA/#endif instead of commenting it out, but that's not a blocker - and maybe we could work a bit on the IDA support ... this package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review