Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Thibault-fonts - Collection of fonts from thibault.org https://bugzilla.redhat.com/show_bug.cgi?id=454128 ------- Additional Comments From matt_domsch@xxxxxxxx 2008-07-16 17:22 EST ------- Reviewing... rpmlint cleanups requested. thibault-fonts.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) thibault-fonts.src: E: description-line-too-long A collection of fonts from thibault.org, including Isabella, Essays1743, StayPuft, and Rockets. thibault-fonts.src: W: no-version-in-last-changelog thibault-fonts.src: W: invalid-license LGPLv2.1 thibault-fonts-essays1743.noarch: E: summary-too-long Thibault.org font based on the typeface used in a 1743 English translation of Montaigne's Essays thibault-fonts-essays1743.noarch: W: no-version-in-last-changelog thibault-fonts-essays1743.noarch: W: invalid-license LGPLv2.1 thibault-fonts-rockets.noarch: W: no-version-in-last-changelog thibault-fonts-staypuft.noarch: W: no-version-in-last-changelog thibault-fonts-isabella.noarch: W: no-version-in-last-changelog 5 packages and 0 specfiles checked; 2 errors, 8 warnings. License tag should be "LGPLv2+", and only at the top, no extra one needed in each %package. BuildRoot could be better. Preferred is %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) other cleanups noted on IRC. Not sure what to do about each of the subpackages owning /usr/share/fonts/thibault/. But seems nuts to make 4 new subdirs under there just to solve it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review