Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-c++ - Native C++ bindings for D-Bus https://bugzilla.redhat.com/show_bug.cgi?id=455575 ------- Additional Comments From adel.gadllah@xxxxxxxxx 2008-07-16 10:25 EST ------- (In reply to comment #3) > formal review: > BAD compiler flags are appropriate. Fixed. > BAD debuginfo package looks complete. Fixed. > - wrong flags are passed to the compiler, looks like package's own Fixed now. (see above) > - can't see any source files in the debuginfo package (depends on the flags issue) Fixed too. > - and I would use the git-archive to generate the source archive, but that's not > any blocker, it would decrease the size from 750 KB to only 50 KB ;-) Done. New spec: http://tgmweb.at/gadllah/dbus-c++.spec New SRPM: http://tgmweb.at/gadllah/dbus-c++-0.5.0-0.3.20080716git1337c65.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review