Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: awesome - Extremely fast, small, dynamic and awesome floating and tiling window manager Alias: awesome https://bugzilla.redhat.com/show_bug.cgi?id=452427 ------- Additional Comments From mnowak@xxxxxxxxxx 2008-07-15 08:14 EST ------- (In reply to comment #8) > libconfuse-devel is listed twice in BuildRequires. It should > certainly be versionned in the BuildRequires too. Sure. Fixed. Both. > For the desktop file, I think that you should better call the > file %{name}.desktop and install it with a cp. The guidelines > are for .desktop files for use in menus. Fixed. > Also it seems to me > that type=application and Icon=awesome32 are wrong for a > xsession .desktop file. Also GenericName doesn't make much sense. Fixed. > > I would suggest using removing the doc installed as part of make > install and use %doc instead. enhanced %configure part + added %doc <...> > /usr/share/awesome/ and /usr/share/awesome/icons are unowned. I hope I fixed it with %dir now. Please, let me know whether still unfixed. (In reply to comment #9) > For reference purposes, this might be useful (or not): I took a look and found it useful, thanks. -- * http://mnowak.fedorapeople.org/awesome/awesome.spec * http://mnowak.fedorapeople.org/awesome/awesome-2.3.2-3.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review