Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: almanah - A application to allow you to keep a diary of your life https://bugzilla.redhat.com/show_bug.cgi?id=447751 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2008-07-13 20:05 EST ------- Review for da202ef7a75b5d85a22b641eef0f61a2 almanah-0.4.0-1.fc9.src.rpm FAIL - MUST: rpmlint /var/lib/mock/fedora-rawhide-i386/result/almanah-* almanah.i386: W: spurious-executable-perm /usr/share/doc/almanah-0.4.0/README almanah.i386: W: spurious-executable-perm /usr/share/doc/almanah-0.4.0/AUTHORS almanah.i386: W: spurious-executable-perm /usr/share/doc/almanah-0.4.0/NEWS almanah-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/almanah-0.4.0/src/main.c almanah-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/almanah-0.4.0/src/main.h almanah-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/almanah-0.4.0/src/interface.c 3 packages and 0 specfiles checked; 0 errors, 6 warnings. You should chown these files in %prep to fix these errors. OK - MUST: The package is named according to the Package Naming Guidelines Ok - MUST: The spec file name matches the base package %{name}, in the format %{name}.spec OK - MUST: The package meets the Packaging Guidelines OK - MUST: The package is licensed with a Fedora approved license (GPLv3+) OK - MUST: The License field in the package spec file matches the actual license OK - MUST: License text from source is included in %doc OK - MUST: The spec file is written in American English OK - MUST: The spec file for the package is legible OK - MUST: The sources used to build the package match the upstream source by md5 59cdbff0ba8e53d736011608aeb6a8e3 OK - MUST: The package successfully compiles and builds into binary rpms on i386 OK - MUST: All build dependencies are listed in BuildRequires OK - MUST: The spec file handles locales properly with %find_lang OK - MUST: The package owns all directories that it creates OK - MUST: The package does not contain any duplicate files in the %files listing FAIL - MUST: Permissions on files are not set properly, see above OK - MUST: The package has a %clean section, which contains rm -rf %{buildroot} OK - MUST: The package consistently uses macros, as described in the macros section of Packaging Guidelines OK - MUST: The package contains code, or permissible content OK - MUST: Files included in %doc do not affect the runtime of the application. FIX? - Consider including ChangeLog, although it's not that important OK - MUST: The package does not contain any .la libtool archives OK - MUST: The package contains a GUI application and includes a %{name}.desktop file that file is properly installed with desktop-file-install FIX - The icon of the desktop file is still diary. To fix this: sed -i 's!Icon=diary!Icon=almanah!' data/%{name}.desktop.in OK - MUST: The packages does not own files or directories already owned by other packages OK - MUST: The package runs rm -rf %{buildroot} at the beginning of %install OK - MUST: All filenames in the package are valid UTF-8 OK - SHOULD: The package builds in mock OK - SHOULD: The package functions as described. There are some issues with encrypted databases, but we can troubleshoot them with upstream once this package is imported and he is back from vacation OK - SHOULD: Latest version of the package NEEDSWORK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review