Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-oauth - PHP Authentication library for desktop to web applications https://bugzilla.redhat.com/show_bug.cgi?id=455039 ------- Additional Comments From steven.moix@xxxxxxxxxx 2008-07-13 13:01 EST ------- This is not a formal review, but I noticed the following points when following the review guidelines: - MUST: The package must be named according to the Package Naming Guidelines. Error, the package version doesn't meet the https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages guidelines Maybe the package has also to be renamed with the php-pear standard? See https://www.redhat.com/archives/fedora-packaging/2008-July/msg00023.html for the discussion. - MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. Error, the creation of a source package matches https://fedoraproject.org/wiki/Packaging/SourceURL "Using Revision Control", but how can you pretend that it's version 1? SVN checkout doesn't work by the way. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review