Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rancid - Really Awesome New Cisco confIg Differ https://bugzilla.redhat.com/show_bug.cgi?id=451189 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-07-13 11:45 EST ------- Well: * Versioning - As the tarball included in the tarball seems pre-version, the versioning should be: 2.3.2-0.XXX.a8%{?dist} where XXX should be incremented every time you modify your spec file. * optflags - Fedora specific compilation flags are not passed correctly to C compiler. https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags You can check what compiler flags are used by $ rpm --eval %optflags Also please check the logs printeded out by rpmbuild command. -------------------------------------------------------------- 365 Making all in bin 366 gmake[1]: Entering directory `/builddir/build/BUILD/rancid-2.3.2a8/bin' 367 gcc -DHAVE_CONFIG_H -I. -I../include -g -O0 -MT hpuifilter.o -MD -MP -MF .deps/hpuifilter.Tpo -c -o hpuifilter.o hpuifilter .c -------------------------------------------------------------- * Macros - Please use macros: https://fedoraproject.org/wiki/Packaging/RPMMacros For example, etc must be %{_sysconfdir}, /var must be %{_localstatedir} or so. * Scriptlet related dependency - Please add "Requires(pre)" or so according to https://fedoraproject.org/wiki/Packaging/UsersAndGroups * Timestamps - When using "cp" or "install" commands, please add "-p" option to keep timestamps on installed files. * /sbin/ldconfig call - The rebuilded binary rpm does not contain any libraries under the default ld search path, so calling /sbin/ldconfig on scriptlets is not needed. * Invalid directory - using /var/_local_ is forbidden. Please use %_localstatedir/%name or so. * Directory ownership issue - Please make it sure that all directories created when installing a package are correctly owned by the rpm. For example, the directories %{_sysconfdir}/rancid/ and %{_datadir}/rancid/ are not owned by any packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review