Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation Alias: pear-Net-IPv4 https://bugzilla.redhat.com/show_bug.cgi?id=448205 fedora@xxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxx 2008-07-13 11:12 EST ------- REVIEW : * rpmlint : W: no-documentation * The package is named according to the Package Naming Guidelines. * source files match upstream: 35ee77683b4fd34d7a9aa77c199b2eda Net_IPv4-1.3.0.tgz * The spec file name match the base package * The package must the PHP Packaging Guidelines * License field in the package spec file match the actual license * license is open source-compatible (PHP) * latest version is being packaged. * The spec file is written in American English * The spec file is legible * build in mock (F-9, noarch) * All build dependencies are listed in BuildRequires * no locales * no shared library files * package own all directories that it creates * Package don't own files or directories already owned by other packages * no duplicate files * Permissions on files are set properly * %clean section * package consistently use macros * The package contain code * no documentation * no library * no desktop file * %install, start with rm -rf %{buildroot} * All filenames are valid UTF-8 * scriptlets are sane * Final Provides ok php-pear(Net_IPv4) = 1.3.0 php-pear-Net-IPv4 = 1.3.0-2.fc9 * Final Requires ok /usr/bin/pear php-pear(PEAR) * install ok * work ok, with litle test case <?php require ("Net/IPv4.php"); $ip = Net_IPv4::parseAddress("192.168.0.4/24"); if ($ip) print_r($ip); else echo "failed\n"; ?> Should just change Remy to Remi in the changelog ;) APPROVED Please wait for you sponsoring before doing the CVS request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review