Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aubio - An audio labelling library https://bugzilla.redhat.com/show_bug.cgi?id=454960 ------- Additional Comments From green@xxxxxxxxxx 2008-07-13 10:49 EST ------- New files: Spec URL: http://spindazzle.org/Fedora/aubio.spec SRPM URL: http://spindazzle.org/Fedora/aubio-0.3.2-2.fc9.src.rpm (In reply to comment #3) > Initial review done, needs some work: > > * License: GPL, GPL is not a valid license tag, it should be "GPLv2+" Fixed. > * Gives the following errors when doing a local build: > RPM build errors: I think this is because you have swig installed. I've BuildRequired swig and created a subpackage for the python bindings. > Installed (but unpackaged) file(s) found: > /usr/lib/python2.5/site-packages/aubio/__init__.py > /usr/lib/python2.5/site-packages/aubio/__init__.pyc > /usr/lib/python2.5/site-packages/aubio/__init__.pyo > /usr/lib/python2.5/site-packages/aubio/_aubiowrapper.so > /usr/lib/python2.5/site-packages/aubio/aubioclass.py > /usr/lib/python2.5/site-packages/aubio/aubioclass.pyc > /usr/lib/python2.5/site-packages/aubio/aubioclass.pyo > <snip> > > It looks like aubio comes with python bindings, it would probably be best to > add the necessary BR's and put the python stuff in a sub-package. > > * rpmlint says: > aubio.src: W: mixed-use-of-spaces-and-tabs (spaces: line 31, tab: line 1) > aubio.x86_64: E: zero-length /usr/share/doc/aubio-0.3.2/NEWS > aubio.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libaubioext.so.2.1.1 > ['/usr/lib64'] > aubio.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/aubiotrack ['/usr/lib64'] > aubio.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/aubioonset ['/usr/lib64'] > aubio.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/aubionotes ['/usr/lib64'] > aubio.x86_64: E: binary-or-shlib-defines-rpath /usr/lib/python2.5/site-packages/ All fixed. Thanks Hans! AG > You can fix this by putting the following 3 lines between %configure and make: > # Don't use rpath! > sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool > sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool > -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review