[Bug 453847] Review Request: gpt - The Grid Packaging Toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gpt - The Grid Packaging Toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=453847





------- Additional Comments From pertusus@xxxxxxx  2008-07-12 05:24 EST -------
In the next iterations, it could be nice to have in the spec file the 
the links to the bugzilla you put in Comment #4 in comment near the 
patch.

I have 2 additional comments regarding the changelog section
* you should remove %{?dist} from the changelog
* I personally prefer when there is a blank line between 2 changelog
  entries, but this is a amatter of preference.


I also like to add a trailing / to directories in %files to mark 
visually that they are directories, once again it is a personal
preference you may ignore. It would lead to this entry in %files:
%{_datadir}/gpt/


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]