Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Auth-OpenID - PHP OpenID https://bugzilla.redhat.com/show_bug.cgi?id=227190 ------- Additional Comments From rakesh.pandit@xxxxxxxxx 2008-07-12 02:21 EST ------- I am not sponsored yet, so these are just suggestios which may help: 1. using sed in place of dos2unix and removes Buildrequire: dos2unix 2. Everything(except doc) gets installed in data folder %{pear_datadir} => /usr/ share/pear/data/ which I believe is wrong. You should use %{pear__phpdir} 3. While building on my machine I get these warnings: (i) WARNING: configuration download directory "/tmp/pear/download" is not writeable. Change download_dir config variable to a writeable dir to avoid this warning This doesn't seem to be an issue, but may be you would like to investigate. Or may be its only with me. (ii) warning: File listed twice: /usr/share/pear/data/Auth_OpenID/ was coming earlier but when I replaced with %{pear_phpdir} same warnings with modified file path. This also seems to be cosmetic issue. I guess it comes because source has not been pear packaged cleanly as %install requires to manually copy files in BUILD. May be you can have a look. My suggestions are based on these changes I made: http://rakesh.fedorapeople.org/patch/openid_spec.patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review