Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Event-ExecFlow - High level API for event-based execution flow control https://bugzilla.redhat.com/show_bug.cgi?id=452523 ------- Additional Comments From xavier@xxxxxxxxxxxx 2008-07-11 18:50 EST ------- + source files match upstream : 79116732b550701a3436a448581e01da + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. - license field matches the actual license : The README file says same license as perl, thus GPL+ or Artistic, but most files say LGPLv2+ + license is open source-compatible. License text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock ( ). + package installs properly - rpmlint is silent : perl-Event-ExecFlow.noarch: E: non-standard-executable-perm /usr/bin/execflow 0555 perl-Event-ExecFlow.noarch: W: file-not-utf8 /usr/share/doc/perl-Event-ExecFlow-0.63/README - final provides and requires are sane: This provide is dubious : perl(AnyEvent::Impl::Event::Glib) + %check is present and all tests pass + owns the directories it creates. - doesn't own any directories it shouldn't. The directories below are installed and owned : /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/auto /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/auto/Event /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/auto/Event/ExecFlow + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review