Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pydotconf - python parser for dot.conf file https://bugzilla.redhat.com/show_bug.cgi?id=454921 ------- Additional Comments From kylev@xxxxxxxxx 2008-07-10 16:07 EST ------- At a glance you're going to need to change your spec quite a bit. Please refer to the packaging guidelines: https://fedoraproject.org/wiki/Packaging/Guidelines https://fedoraproject.org/wiki/Packaging/Python In particular, don't include a Vendor, don't define things like name and version needlessly, Source0 should be an URL, URL should be the package's home page, and the package needs to be named python-pydotconf. (Not to mention that putting "py" in the name of your python library is a bit silly. Why not just name it dotconf? Also, you should consider reading PEP-8 and just rolling everything into a single dotconf.py instead of a directory... it's only about 350 lines.) You should also install the rpmdevtools RPM and use the "rpmdev-newspec -t python" to generate a python-esque base .spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review