Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: germanium - a download manager for eMusic.com https://bugzilla.redhat.com/show_bug.cgi?id=454220 ------- Additional Comments From rhbugs@xxxxxxxxxxxxxxxx 2008-07-10 10:51 EST ------- (In reply to comment #9) > Thanks for the patches. I've applied most verbatim, but I've moved the Python > modules from $(libdir) to $(datadir) instead of the suggested $(pkgpythondir). > Python's "site-packages" dir is meant for actual Python libraries, so I don't > want to dump modules internal to my app in there. If I was going to put > anything in site-packages I'd want to organize it as a regular Python package > first instead of a bunch of individual modules. I placed it into a subdirectory "germanium-0.2.0" in the site-packages directory exactly because it is just germanium internal stuff. That dir is not added to sys.path without further action, and you can even install germanium-0.2.1 in parallel without a naming conflict. (In reply to comment #10) Use #!@PYTHON@ in germanium/germanium.py and then add -e 's|[@]PYTHON@|$(PYTHON)' to the sed line in germanium/Makefile.am. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review