Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: heimdal - Heimdal Kerberos libraries and KDC https://bugzilla.redhat.com/show_bug.cgi?id=452212 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2008-07-10 09:07 EST ------- A few initial (minor) comments: 1. BuildRoot doesn't match any of those recommnded in packaging guidelines. 2. in -libs, Requires(preun,post): info, /sbin/install-info is extraneous, Requires(...): /sbin/install-info is sufficient 3. -clients: Groups: Networking/Other isn't used in Fedora. maybe use something like (matching krb5-workstation-clients): Group: System Environment/Base while you're at it, maybe also consider using a subpkg name -workstation-clients to match krb5 as well. 4. Consider using %{?dist} tag in Release, something like: Release: 1%{?dist} Submitted a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=707572 failed. 5. looks like missing deps, per: xnlock.c:18:28: error: X11/StringDefs.h: No such file or directory xnlock.c:19:27: error: X11/Intrinsic.h: No such file or directory xnlock.c:21:23: error: X11/Shell.h: No such file or directory so, add BuildRequires: libXt-devel 6. build failed again with Installed (but unpackaged) file(s) found: /usr/share/info/dir.gz so, need to remove that in %install (or otherwise omit from packaging) 7. shlibs. I noticed -libs includes all shlibs, but libkdc.so.*, libhdb.so.* and libkadm5srv.so.* are (also) included in -server. On purpose or oversight? 8. -devel installs a pkgconfig file, so this subpkg should include Requires: pkgconfig fixed 5,6 submitted new build: http://koji.fedoraproject.org/koji/taskinfo?taskID=707650 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review