Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jscoverage - A tool that measures code coverage for JavaScript programs https://bugzilla.redhat.com/show_bug.cgi?id=453264 bdpepple@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From bdpepple@xxxxxxxxx 2008-07-07 21:17 EST ------- MD5Sum: 8e06fb1d7fdc06b02f5e79093908157e jscoverage-0.3.2rc1.tar.bz2 Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Valid license tag * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * Files have appropriate permissions and owners * Package installs and uninstalls clean Bad (non-blockers): * As tibbs noted in comment #4, there is a test suite in the tarball that might might be worth running. * The devel subpackage bits can probably be dropped, since your not packaging anything for it. * rpmlint produces the following errors that should be fixed before importing into CVS: jscoverage.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/jscoverage-0.3.2/doc/example-jsunit/jsunit/licenses/gpl-2.txt jscoverage.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/jscoverage-0.3.2/doc/example-jsunit/jsunit/app/xbDebug.js jscoverage.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/jscoverage-0.3.2/doc/example-jsunit/jsunit/app/css/readme <etc.> +1 APPROVE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review