Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: germanium - a download manager for eMusic.com https://bugzilla.redhat.com/show_bug.cgi?id=454220 mnowak@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnowak@xxxxxxxxxx ------- Additional Comments From mnowak@xxxxxxxxxx 2008-07-07 12:24 EST ------- > make %{?_smp_mflags} * Omit '%{?_smp_mflags}' in python package, this won't speed up anything. Usable only when compiling C/C++(/Fortran) code. > %configure --disable-mime-update --disable-update-desktop --prefix=/usr --sysconfdir=/etc --libdir=/usr/share * This hardwired paths are not proper. Use ones from https://fedoraproject.org/wiki/Packaging/RPMMacros in case you really need them. Don't forget that rpmbuild probably populates the configure variables in a good manner. Familiarize yourself more with https://fedoraproject.org/wiki/Packaging/Python and python_sitelib. * Please post results of rpmlint. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review