Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtest - Google C++ testing framework https://bugzilla.redhat.com/show_bug.cgi?id=454125 rakesh.pandit@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rakesh.pandit@xxxxxxxxx ------- Additional Comments From rakesh.pandit@xxxxxxxxx 2008-07-05 15:18 EST ------- I am not sponsored yet. This is an unofficial review rpmlint produces no output. Required: [x] package and spec file named against package naming guidelines [x] license tag matches with actual license used. Source and package both have identical license copies. Included in %doc [x] spec file has permissible content, is legible and written in American English [x] md5sum for source (at project page) and source inside srpm meet - md5sum 669530b4399d8e02c1c96483bd939f6c [x] successfully build and compiled on different platforms (used koji to build on ppc, ppc64, i386, x86_64) [x] Build dependency - chrpath listed in BuildRoot [-] Handle locales -- N/A [-] relocatable -- N/A [x] owns all directories created [x] permissions okay [x] %clean section present [x] macros used consistently [x] Header files in -devel package [x] static libraries --disabled [x] base devel package requirement fully versioned dependency Requires: %{name} = %{version}-%{release} Checked [x] *.la libtool archives removed [x] No GUI -- %{name}.desktop not required [x] at beginning of %install and %clean removes buildroot -- Checked [x] All files are utf-8 [x] -devel subpackage only has symlinks so ldconfig not required in subpackage [x] package meets package guideline Optional: [x] Includes license -- no need to query upstream [x] description and summary translations -- not available [x] No file dependency outside /etc, /bin/sbin, /usr/bin, /usr/sbin Key - = N/A, x = Check, ! = Problem, ? = Not evaluated Package looks Okay to me -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review