Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ht - File editor/viewer/analyzer for executables https://bugzilla.redhat.com/show_bug.cgi?id=245561 ------- Additional Comments From opensource@xxxxxxxxx 2008-07-04 18:52 EST ------- I changed the version in the spec to 2.0.13 and the rpm built fine. Here is my review: - rpmlint: good enough: ht.i386: W: file-not-utf8 /usr/share/doc/ht-2.0.13/TODO This should probably be reported to upstream because file says: $ file TODO TODO: Non-ISO extended-ASCII English text - naming: ok - license: ok, GPLv2, included - builds on koji for dist-f10: ok - no libraries / subpackages: ok - not a gui tool, no .desktop needed: ok - %install: ok - %clean: ok - Honoring %optflags: NOT OK: build.log shows usage of -O3 -fomit-frame-pointer and the Fedora optflags are not used - BuildRequires: NOT OK: It should BR: lzo-devel, because otherwise it uses a local copy of minilzo instead of the Fedora lzo library -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review