Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: guake - Drop-down terminal for GNOME https://bugzilla.redhat.com/show_bug.cgi?id=450189 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-07-04 08:15 EST ------- (In reply to comment #17) > > By the way, when adopting your patch, please keep in mind that your patch > > adds some BuildRequires > What?? Patch "add" only dependency "grep", but it is now successfully used in > configure script without my patch. So, my patch do not add any additional > dependency! You are confusing "Requires" vs "BuildRequires" by the word "dependency". "BuildRequires (here not mentioning about Requires): pygtk2, vte" are also needed if your patch is applied. With the patch by Jean-François, "BuildRequires (not Requires) pygtk2, vte" is _not_ needed. (*Requires*: pygtk2, vte is needed anyway) > >(perhaps you are usually using Mandriva, however Fedora people are very > sensitive to Requires/BuildRequires and many other packging issue ). > > No, no, no. I'm Fedora user is not one year. Did not even try Mandriva. You make > this assumption by macroses like > %post_install_gconf_schemas/%preun_uninstall_gconf_schemas?? Yes, this macroses > comes from Mandriva (as I remember, it is from internet) it is just usefull > macroses, I'm may replace it's by hardcoded instructions, if will need. I guessed so because of the line "--add-category="X-MandrivaLinux-System-Terminals" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review