Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iw - A nl80211 based wireless configuration tool https://bugzilla.redhat.com/show_bug.cgi?id=453870 ------- Additional Comments From lemenkov@xxxxxxxxx 2008-07-03 08:34 EST ------- Remarks: * You shpuld add comments describin how to create provided in Source0 tarball. E.g.something like: # svn export http://example.com/svn/name/trunk name-1.0.0 # tar cjvf name-1.0.0.tar.bz2 name-1.0.0 Source0: name-1.0.0.tar.bz2 * You may simplify installation process. Instead of mkdir -p $RPM_BUILD_ROOT%{_bindir} install -m 0755 %{name} $RPM_BUILD_ROOT%{_bindir}/%{name} you may do it in the following way: install -D -p -m 0755 %{name} $RPM_BUILD_ROOT%{_bindir}/%{name} Note -p (preserves timestamps) and -D (creates all necessary directories). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review