Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nagios-plugins-rsync - Nagios plugin to monitor remote rsync servers https://bugzilla.redhat.com/show_bug.cgi?id=423821 ------- Additional Comments From lemenkov@xxxxxxxxx 2008-07-03 06:20 EST ------- Few initial remarks: * URL changed to http://www.nagiosexchange.org/cgi-bin/page.cgi?g=Detailed%2F2094.html;d=1 * No need to create directory - install can do it. install -D -p -m 755 check_rsync $RPM_BUILD_ROOT/%{nagios_plugins_dir}/check_rsync e.g. you may remove the following line: install -d -m 755 $RPM_BUILD_ROOT/%{nagios_plugins_dir} * Missing requires. At least: Requires: perl(Test::Simple) Consider applying these suggested changes and I'll review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review