Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trustyrc - IRC robot fully modular https://bugzilla.redhat.com/show_bug.cgi?id=452911 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-07-02 18:16 EST ------- I note you didn't update the summary. I'm not going to block this package because of language issues, but I would really suggest using something like the following, which I have written using your original text and applying as few changes as I could in order to make the result parse in English: Summary: Fully modular IRC robot %description trustyRC is a fully modular IRC robot which includes all of the common bot features (channel moderation, administration, account system, quotes) and much more. trustyRC is comprised of a a kernel and a plugin loader which loads features such as a log system, configuration parser, networking, etc. All plugins can communicate with others, providing a highly flexible system. A plugin can be loaded or unloaded while the bot is running, so if a plugin needs to be updated, it can be unloaded, rebuilt and reloaded. During this, the bot does not need to be stopped. Plugins are stored in shared libraries; a plugin's features are available to the bot when the plugin is loaded and those features are removed when the plugin is unloaded. * source files match upstream: 3a499e5a9303f77e5e6b5fdb93abaefe8d4a906476d0e1eabb1a1241a644b502 trustyrc-0.1.1.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. ? summary is difficult to understand in English. ? description is very difficult to parse in English. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane: trustyrc-0.1.1-2.fc10.x86_64.rpm config(trustyrc) = 0.1.1-2.fc10 trustyrc = 0.1.1-2.fc10 = config(trustyrc) = 0.1.1-2.fc10 libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.9)(64bit) libtinyxml.so.0()(64bit) trustyrc-plugins trustyrc-plugins-0.1.1-2.fc10.x86_64.rpm admin.so()(64bit) ctcp.so()(64bit) ignore.so()(64bit) infos.so()(64bit) moderation.so()(64bit) module.so()(64bit) ping.so()(64bit) postconnect.so()(64bit) usersinfos.so()(64bit) trustyrc-plugins = 0.1.1-2.fc10 = libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) trustyrc = 0.1.1 trustyrc-plugins-extras-0.1.1-2.fc10.x86_64.rpm advertising.so()(64bit) bashfr.so()(64bit) bzrh.so()(64bit) fedorafr.so()(64bit) fedoraproject.so()(64bit) gameserver.so()(64bit) ipconverting.so()(64bit) lamoule.so()(64bit) magic8ball.so()(64bit) pluginsample.so()(64bit) quotes.so()(64bit) slapme.so()(64bit) survey.so()(64bit) tele.so()(64bit) trad.so()(64bit) trustyrc-plugins-extras = 0.1.1-2.fc10 = libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) trustyrc = 0.1.1 * %check is not present; no test suite upstream. I've no idea how to test this package. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review