Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: prelude-correlator - Correlates IDMEF events for prelude-manager https://bugzilla.redhat.com/show_bug.cgi?id=453224 tmraz@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tmraz@xxxxxxxxxx 2008-06-30 13:22 EST ------- rpmlint -v prelude-correlator-0.9.0-0.1.beta1b.fc9.src.rpm prelude-correlator.src: I: checking prelude-correlator.src: W: mixed-use-of-spaces-and-tabs (spaces: line 21, tab: line 76) prelude-correlator.src: W: strange-permission prelude-correlator.init 0755 1 packages and 0 specfiles checked; 0 errors, 2 warnings. OK rpmlint -v prelude-correlator-0.9.0-0.1.beta1b.fc9.x86_64.rpm prelude-correlator.x86_64: I: checking prelude-correlator.x86_64: E: non-standard-dir-perm /etc/prelude-correlator/lua-rules 0700 prelude-correlator.x86_64: E: non-standard-dir-perm /etc/prelude-correlator 0700 prelude-correlator.x86_64: E: zero-length /usr/share/doc/prelude-correlator-0.9.0/AUTHORS prelude-correlator.x86_64: W: incoherent-subsys /etc/rc.d/init.d/prelude-correlator $prog prelude-correlator.x86_64: W: incoherent-subsys /etc/rc.d/init.d/prelude-correlator $prog 1 packages and 0 specfiles checked; 3 errors, 2 warnings. OK (with comments above) rpmlint -v prelude-correlator-devel-0.9.0-0.1.beta1b.fc9.x86_64.rpm prelude-correlator-devel.x86_64: I: checking prelude-correlator-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. OK rpmlint -v prelude-correlator-debuginfo-0.9.0-0.1.beta1b.fc9.x86_64.rpm prelude-correlator-debuginfo.x86_64: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. OK I've noticed one more thing - please remove the calls to /sbin/ldconfig from %post and %postun, the package doesn't contain any libraries (the lua.so bindings are not a regular library and are placed correctly in a subdirectory). So given you fix the above APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review