Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sippy - B2BUA SIP call controlling component https://bugzilla.redhat.com/show_bug.cgi?id=446841 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-29 15:37 EST ------- This did not build for me: Processing files: sippy-0-1.20080515cvs.fc10 Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.38465 error: File not found by glob: /var/tmp/sippy-0-1.20080515cvs.fc10-root-mockbuild/usr/lib64/python2.5/site-packages/* and later: Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/sippy-0-1.20080515cvs.fc10-root-mockbuild error: Installed (but unpackaged) file(s) found: /usr/lib/python2.5/site-packages/sippy-0.0-py2.5.egg-info /usr/lib/python2.5/site-packages/sippy/CCEvents.py /usr/lib/python2.5/site-packages/sippy/CCEvents.pyc and so on, for every installed file. Looks like you're using sitearch when you should be using sitelib, since this is a noarch package. I can't imagine that this package could ever actually build, but somehow you got rpmlint output. As you currently have things, this is just a python module and should be called python-sippy. Even if it has some scripts but is still mainly used as a module, I'd name it as a module. But if it's an application that happens to bundle modules for its own use, then name it after the application. If you expect that the examples will actually need to be called by people during regular use then they should be in _bindir. Otherwise they should be packaged as documentation, and generally not be made executable. Although it's not really a problem (i.e. a review blocker) for them to be executable as long as they don't pull in dependencies that the package wouldn't have were they not executable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review