Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? Bug 452688 depends on bug 452251, which changed state. Bug 452251 Summary: Review Request: libmatthew-java - collection of java libraries https://bugzilla.redhat.com/show_bug.cgi?id=452251 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |CURRENTRELEASE ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-29 14:50 EST ------- This builds fine. The only rpmlint complaint is: dbus-java.x86_64: W: incoherent-version-in-changelog 2.5-1.fc9 2.5-1.fc10 which happens because I'm building this on rawhide. Normally you just don't include the dist tag in your changelog versions. I'm a bit confused by the installed wrapper scripts; they all contain: JARPATH=/usr/local/share/java which doesn't seem correct. Installing and running ListDBus gives me: Exception in thread "main" java.lang.NoClassDefFoundError: org/freedesktop/dbus/bin/ListDBus Caused by: java.lang.ClassNotFoundException: org.freedesktop.dbus.bin.ListDBus at java.net.URLClassLoader$1.run(URLClassLoader.java:217) [...] The guidelines are unfortunately silent on the subject of symlinking the jar files, but this seems to be common enough. * source files match upstream: 2b2001aa2fccc6cc3eedfeb35d2c7b13e52811c27820f27f0f6ce0e8f547ad65 dbus-java-2.5.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. X rpmlint has one minor complaint which is easy to fix. * final provides and requires are sane: dbus-java-2.5-1.fc10.x86_64.rpm dbus-2.5.jar.so()(64bit) dbus-bin-2.5.jar.so()(64bit) dbus-viewer-2.5.jar.so()(64bit) dbus-java = 2.5-1.fc10 = /bin/sh java-1.6.0-openjdk java-gcj-compat >= 1.0.31 jpackage-utils libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcj_bc.so.1()(64bit) libz.so.1()(64bit) dbus-java-javadoc-2.5-1.fc10.x86_64.rpm dbus-java-javadoc = 2.5-1.fc10 = jpackage-utils X %check is not present; no test suite upstream. I'm not sure how to test this, honestly, since I don't know much about dbus, but just running ListDBus seems to fail badly. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK; gcj-rebuild-db stuff. * code, not content. * %docs are not necessary for the proper functioning of the package. * no pre-built jars * single jar, named after the package * jarfiles are under _javadir. * javadocs are under _javadocdir. X wrapper scripts provided, but not working properly. * gcj called properly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review