Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Samba4 - Samba4 CIFS and AD server and client https://bugzilla.redhat.com/show_bug.cgi?id=453083 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-29 13:57 EST ------- Then I guess the next question is whether you would like a review of this now or whether you've opened this to track the development effort. Not that I can promise to do a review myself, of course; this is a big package and several people will probably needed share the review work. Some initial comments from a quick look at the spec; I did not build the package: Please use the proper versioning scheme for prerelease packages: Release: 0.1.alpha%{alpha_version}%{?dist} ^ and increment the '1' with each new release until 4.0.0 is actually released, at which point you can just go to "Release: 1%{?dist}". See http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages Please use the correct License: tag; comma-separation is ambiguous and not valid. I'm not sure if the code is triple-licensed or if different pieces of the built package have different licenses, but both situations are covered in http://fedoraproject.org/wiki/Packaging/LicensingGuidelines. Any possibility of parallel make? The ldconfig call in %install is confusing to me. What's it for? Please use the proper scriptlets for user/group creation; http://fedoraproject.org/wiki/Packaging/UsersAndGroups Shouldn't the condrestart go in %postun, not %post? You need the proper dependencies for the scriptlets. Requires(post): /sbin/chkconfig, /sbin/service and so on. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review