Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: clive - Video extraction tool for user-uploaded video hosts https://bugzilla.redhat.com/show_bug.cgi?id=450466 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-28 21:31 EST ------- Yes, I think this package is fine. I don't really see anything worth commenting on. * source files match upstream: c00cc9e1387b26c1a1d3f0a82dd39bbd05c2598a645124bc2efb006d8d21e61d clive-0.4.16.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: clive = 0.4.16-3.fc10 = /usr/bin/env newt-python python(abi) = 2.5 python-feedparser python-urlgrabber xclip * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review