Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: NPusers - Adds NOCpulse production users https://bugzilla.redhat.com/show_bug.cgi?id=453109 ------- Additional Comments From lkundrak@xxxxx 2008-06-28 17:40 EST ------- Sorry for not being more constructive, but the package needs to be completely reworked to be acceptable for Fedora, and in its current state can not serve as a basis for any constructive criticism. I recommend you to spend some time getting comfortable with the packaging guidelines: https://fedoraproject.org/wiki/Packaging/Guidelines Also, reading existing Fedora SPEC files may help a lot: http://cvs.fedoraproject.org/viewcvs/rpms When it comes to tooling, you'll definitely appreciate rpmlint and rpmdev-tools. rpmdev-newspec may give you a good starting point for a reworked package. Also, I'll gladly help to resolve problems that may arise during your packaging attempts. NB: This package and bug #453111 should probably be integrated into a single package with nocpulse, unless there are really good reasons against it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review