Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: NPusers - Adds NOCpulse production users https://bugzilla.redhat.com/show_bug.cgi?id=453109 ------- Additional Comments From lkundrak@xxxxx 2008-06-28 17:34 EST ------- Do not consider it an offense, but this is very poorly pacakged, with minimal effort spent to comply with Fedora quality requirements. A couple of examples: 1.) This is completely pointless, please do not do it Source9999: version Version: %(echo `awk '{ print $1 }' %{SOURCE9999}`) Release: %(echo `awk '{ print $2 }' %{SOURCE9999}`)%{?dist} 2.) Do not use file dependencies, as they are slow, unless you have to. This is not the case here, all these are in well-known packages. Requires: /usr/sbin/useradd /bin/chmod /bin/false /usr/bin/passwd /bin/chown /bin/awk Also, for ones you use it in install-time scriptlets use Requires(pre): and Requires(post): respectively. You also use a couple of more utilities, such as ssh-keygen, which you completely miss a require for. 3.) You do not define %main_source anyhere. FWIW, these lines are completely useless %define build_sub_dir %(echo %{main_source} | sed 's/\.tar\.gz$//') %setup -n %build_sub_dir 4.) Replace absolute paths with macros, such as %{_sysconfdir} and %{_localstatedir}. See rpm --showrc for more. # Install the user creation script install -m 755 -d %buildroot/etc/nocpulse install -m 755 -d %buildroot/var/log/nocpulse ... 5.) Completely incorrect %files list %pre ... # Setting up nocpulse homedir and ssh key pair for dir in /etc/nocpulse /var/lib/nocpulse/{,.ssh,var{,/archives}} do if [ ! -d $dir ] then mkdir -p $dir fi done /usr/bin/ssh-keygen -q -t dsa -N '' -f /var/lib/nocpulse/.ssh/nocpulse-identity chown -R nocpulse.nocpulse /var/lib/nocpulse %files %defattr(-,nocpulse,nocpulse) %dir /etc/nocpulse %dir /var/log/nocpulse Files list refers to the state of the tree at package build time. Files that are created at install- or run-time should use %ghost. 6.) You are obviously not on Solaris in Fedora; do you really need to keep Solaris stuff here? Also this seems to deal with user and group management, see https://fedoraproject.org/wiki/Packaging/Guidelines#Users_and_Groups if [ $OSTYPE = solaris ] ; then SOLARIS=true sysacct= wheel_group=apache oracle_group=dba tcsh=/usr/local/bin/tcsh orac else SOLARIS= sysacct=-r wheel_group="-G apache" oracle_group=oinstall tcsh=/bin/tcsh fi I could proceed on an on; (%build section missing, etc., etc.) but the package is really not ready for any qa, running rpmlint would be a nonsense at this point. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review