Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rcssserver3d - Robocup Soccer Simulation Server 3D https://bugzilla.redhat.com/show_bug.cgi?id=450409 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-06-28 13:43 EST ------- For 0.6-2 * SourceURL - %SOURCE0 tarball could not be found from the URL written as %SOURCE0. Maybe: http://downloads.sourceforge.net/sserver/%{name}-%{version}.tar.gz ? * Source1 - Please specify the URL of (or how you received) %SOURCE1 * Macros - Please use macros properly. /usr/bin should be %{_bindir}. * libtinyxml.so linkage -------------------------------------------------------------------- 2382 g++ -shared -nostdlib /usr/lib/gcc/i386-redhat-linux/4.3.1/../../../crti.o /usr/lib/gcc/i386-redhat-linux/4.3.1/crtbeginS.o .libs/export.o .libs/roselements.o .libs/rosimporter.o .libs/rosimporter_c.o -Wl,--rpath -Wl,/builddir/build/BUILD/rcssserver3d-0.6/utility/tinyxml/.libs -Wl,--rpath -Wl,/usr/lib/rcssserver3d /builddir/build/BUILD/rcssserver3d-0.6/utility/tinyxml/.libs/libtinyxml.so -L/usr/lib/gcc/i386-redhat-linux/4.3.1 -L/usr/lib/gcc/i386-redhat-linux/4.3.1/../../.. -lstdc++ -lm -lc -lgcc_s /usr/lib/gcc/i386-redhat-linux/4.3.1/crtendS.o /usr/lib/gcc/i386-redhat-linux/4.3.1/../../../crtn.o -m32 -march=i386 -mtune=generic -Wl,-soname -Wl,rosimporter.so -o .libs/rosimporter.so 3902 + rm -rf /var/tmp/rcssserver3d-0.6-2.fc10-root-mockbuild//usr/lib/rcssserver3d/libtinyxml.so /var/tmp/rcssserver3d-0.6-2.fc10-root- mockbuild//usr/lib/rcssserver3d/libtinyxml.so.0 /var/tmp/rcssserver3d-0.6-2.fc10-root-mockbuild//usr/lib/rcssserver3d/libtinyxml.so.0.0.0 -------------------------------------------------------------------- - When building rosimporter.so, the internal libtinyxml.so is used, however when installing rosimporter.so, the internal libtinyxml.so is removed. This is dangerous because system-wide libtinyxml.so may change sover or may have different ABI than the internal libtinyxml.so. You should create a patch which makes it sure that rosimporter.so is actually linked against system wide libtinyxml.so. * Timestamps - To keep timestamps on more files to be installed, please apply the following: -------------------------------------------------------------------- sed -i.stamp -e 's|cp -r|cp -pr|' app/simspark/Makefile.{am,in} -------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review