Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: antlr3 - ANother Tool for Language Recognition https://bugzilla.redhat.com/show_bug.cgi?id=441141 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-27 19:38 EST ------- Yes, that one builds. It's a bit odd for >800 source files to turn into one jar and two bits of documentation, but as I have no idea at all how to test this, I'll take your word that everything that needs to be in there is in there. No AOT compilation is done, which is OK since it's only a SHOULD in the guidelines. Everything looks good to me. * source files match upstream: 99fe1b65071e91e5ac378cd7338742f1269a069147525639c654236d60c8fd77 antlr-3.0.1.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: antlr3 = 3.0.1-2.fc10 = jpackage-utils * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * %docs are not necessary for the proper functioning of the package. * no pre-built jars * single jar, named after the package * jarfiles are under _javadir. * ant called properly. * gcj not called. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review