Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Math-FFT - Perl extension for Fast Fourier Transforms https://bugzilla.redhat.com/show_bug.cgi?id=452832 ------- Additional Comments From lkundrak@xxxxx 2008-06-27 09:46 EST ------- Miroslav: Thanks for the updated package. Please note that relocatable packages are deprecated for Fedora [1], so not being relocatable is not an issue at all. [1] http://fedoraproject.org/wiki/Packaging/Guidelines#Relocatable_packages RPMLint is quiet. Spec file is clean legible. 1.) Licensing Seems like the copyright status of several pieces of code is not known. As per module's documentation [2], fft4g.c is not necessarily covered by this module's license. According to original author's [3] website, the file is public domain. Please do the following: * Add " and Public Domain" to the License: tag, and accompany it with a comment about which parts of the code are covered by which license. * Encourage the upstream author to include verbatim copy of the copyright disclaimer (as in [3]) in this package's documentation. [2] http://search.cpan.org/dist/Math-FFT/FFT.pm#COPYRIGHT [3] http://www.kurims.kyoto-u.ac.jp/~ooura/fft.html arrays.c file that comes from PGPLOT package is covered by the very same license as this module's code [4]. You are encouraged to ask this package's upstream to reflect this fact in their documentation, and please add appropriate comment to the License: tag in your spec file as well. [4] http://search.cpan.org/src/KGB/PGPLOT-2.20/LICENSE 2.) Package does not build due to lacking dependencies Addding BuildRequires: perl(ExtUtils::MakeMaker.pm) might be enough. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review