Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trustyrc - Fully modular IRC robot https://bugzilla.redhat.com/show_bug.cgi?id=452911 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-27 01:10 EST ------- I just took a quick look. Here are a few comments: The compiler is not called with the proper flags (%{optflags} or $RPM_OPT_FLAGS depending on your preference). This misses all of the default Fedora security options and results in the debuginfo package missing all of the source code. I'd say the security options are especially important for something that's going to be subjected to constant untrusted network input such as an IRC bot. If you're going to use "%{__sed}" instead of "sed", you need to use "${__rm}" instead of "rm". I personally prefer the non-macro versions, but it's up to you; just be consistent. The license seems to me to be GPLv2+; where do you see it restricted to v2 only? The source files include the "any later version" language. A couple of English notes: "IRC robot fully modular" sounds better as the summary of this ticket: "Fully modular IRC robot". "Extras plugins" should be "Extra plugins". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review