Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pytrainer - A tool to log all your sport excursions https://bugzilla.redhat.com/show_bug.cgi?id=443469 katzj@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|katzj@xxxxxxxxxx |silfreed@xxxxxxxxxxxx Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ ------- Additional Comments From katzj@xxxxxxxxxx 2008-06-26 15:35 EST ------- Okay, more comprehensive review: * Needs to own %{_datadir}/pytrainer directory rather than just the contents of the directory * I thought we had removed the need for --vendor from the desktop-file-install, but guidelines still include it so I may be mistaken Otherwise, looks good. Fix up the first one before importing it and then once you get the license clarification, include that as well as having the license file as %doc. But APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review