Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xdialog - X11 drop in replacement for cdialog https://bugzilla.redhat.com/show_bug.cgi?id=446102 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-06-25 21:11 EST ------- I have tried a mock build and it gives the following error: Making all in po make[2]: Entering directory `/builddir/build/BUILD/Xdialog-2.3.1/po' test -z "fr.gmo de.gmo ru.gmo es.gmo hu.gmo pt_BR.gmo no_NO.gmo id.gmo nl.gmo it.gmo pl.gmo ca.gmo sv_SE.gmo" || make fr.gmo de.gmo ru.gmo es.gmo hu.gmo pt_BR.gmo no_NO.gmo id.gmo nl.gmo it.gmo pl.gmo ca.gmo sv_SE.gmo make[3]: Entering directory `/builddir/build/BUILD/Xdialog-2.3.1/po' rm -f fr.gmo && : -c --statistics -o fr.gmo fr.po rm -f de.gmo && : -c --statistics -o de.gmo de.po mv: cannot stat `t-de.gmo': No such file or directory rm -f ru.gmo && : -c --statistics -o ru.gmo ru.po mv: cannot stat `t-fr.gmo': No such file or directory make[3]: *** [de.gmo] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: *** [fr.gmo] Error 1 mv: cannot stat `t-ru.gmo': No such file or directory make[3]: *** [ru.gmo] Error 1 make[3]: Leaving directory `/builddir/build/BUILD/Xdialog-2.3.1/po' make[2]: *** [stamp-po] Error 2 make[2]: Leaving directory `/builddir/build/BUILD/Xdialog-2.3.1/po' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/builddir/build/BUILD/Xdialog-2.3.1' make: *** [all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.71846 (%build) Adding gettext-devel as BR solves that. Once adding that I see no real blockers except for one small problem. On one hand, the guidelines require the presence of a desktop file. On the other hand this application (which works OK in Fedora 7, BTW) needs arguments to be provided to it, so a mere desktop file will be useless. Maybe we could add a comment to the spec specifying why no desktop file is included ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review